Issue 43 - Support JDKs beyond 8 #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaces the use of javax jaxb artifacts with jakarta jaxb and the jaxb2-maven plugin. - Removes tools.jar and other artifacts no longer available as of Java 9. - Replaces use of the antrun plugin with xml-maven-plugin.
seidewitz
changed the title
scinnamond
approved these changes
Apr 3, 2023
Contributor
scinnamond
left a comment
scinnamond
left a comment
There was a problem hiding this comment.
assuming same tests are passing as with previous release (?)
Contributor
Author
|
Yes, all the Junit tests in the Maven build pass. |
Contributor
|
Great Ill push it to Central as the specified release when you merge it.
--S
…On Mon, Apr 3, 2023 at 3:03 PM Ed Seidewitz ***@***.***> wrote:
Yes, all the Junit tests in the Maven build pass.
—
Reply to this email directly, view it on GitHub
<#49 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQVKMCE6XTCXPOATGOA67DW7NCLXANCNFSM6AAAAAAWPLTLG4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR request addresses Issue #43 by removing the use of artifacts no longer supported since JDK 9. It is tested on JDK 8 and 11.